feat: consolidate enable parameters to locals and fix invalid count bug #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoseSecurity
changed the title
|
/terratest |
joe-niland
approved these changes
May 16, 2025
|
These changes were released in v0.26.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
enabledlogic into localslocal.enabled && length(var.master_password) == 0Note
length()returns an integer, so the result is always plan-time-known, even when the underlying string is deferredcountexpression withcount = module.this.enabled && local.is_master_password_empty ? 1 : 0.why
count = module.this.enabled && var.master_password == "" ? 1 : 0expression referencedvar.master_password, which, when wired to something likeaws_ssm_parameter.db_password.value, is unknown until apply timereferences